Align default IDs in Task.ts file#54960
Conversation
| // eslint-disable-next-line @typescript-eslint/non-nullable-type-assertion-style | ||
| report.parentReportID as string, |
There was a problem hiding this comment.
@fabioh8010 As I know @pac-guerreiro is working on making report.parentReportID to be required for tasks in his PR, based on this discussion. So I'm not sure if I should change the typing for parentReportID to string | undefined
There was a problem hiding this comment.
If we merge this PR sooner – we'll need to ensure we handle this in @pac-guerreiro's PR.
There was a problem hiding this comment.
I've removed the assertion and updated typing instead:
- this way, if typing is wrong it will be catched by TS and fixed for sure
- also, it looks like the PR I mentioned shouldn't effect specifically this place
This comment was marked as outdated.
This comment was marked as outdated.
|
@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.webmAndroid: mWeb Chromechrome.webmiOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-10.at.13.21.53.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-10.at.10.29.04.mp4MacOS: Chrome / SafariScreen.Recording.2025-01-10.at.10.20.44.movMacOS: DesktopScreen.Recording.2025-01-10.at.10.18.19.mov |
neil-marcellini
left a comment
There was a problem hiding this comment.
Looks good, thank you
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.85-0 🚀
|
3 similar comments
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.85-0 🚀
|
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.85-0 🚀
|
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.85-0 🚀
|
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.85-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.85-4 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.85-4 🚀
|
Explanation of Change
Align default IDs in Task.ts file
Fixed Issues
$ #50360
PROPOSAL: N/A
Tests
Offline tests
Same, as in the Tests section
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same, as in the Tests section
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
andr1.mp4
Android: mWeb Chrome
android_web1.mp4
iOS: Native
ios1.mp4
iOS: mWeb Safari
ios_web1.mp4
MacOS: Chrome / Safari
web1.mp4
MacOS: Desktop
desktop1.mp4